Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plot in editor tab flag #6148

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Remove plot in editor tab flag #6148

merged 1 commit into from
Jan 30, 2025

Conversation

timtmok
Copy link
Contributor

@timtmok timtmok commented Jan 28, 2025 •
edited
Loading

@:plots

Release Notes

New Features

  • Remove experimental flag for plots in editor tabs #6146 Lifts the experimental flag on viewing plots in an editor tab. This feature introduces an action menu button in the Plots view to open a plot for viewing in an editor. The default action opens the plot in a new window. The menu options allow opening the plot in the same window either in the existing editor group or to the side of the existing group. Selecting an alternate location sets it as the default action. This is setting is remembered for the project. Plots in an editor tab are rendered separately from the Plots view so they can have their own sizing policy.

Bug Fixes

  • N/A

QA Notes

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:plots

readme  valid tags

@timtmok timtmok requested a review from sharon-wang January 29, 2025 21:46
@timtmok timtmok marked this pull request as ready for review January 29, 2025 21:47
sharon-wang
sharon-wang approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@sharon-wang sharon-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo!! 🎉

Looks good on dev Mac Desktop and Server Web:
image

Open plot in new window in dev Server Web looks to have the same "new window" issue as #5090. If it's the same underlying issue, this shouldn't be a problem in release builds though!

image

note to QA verification

please try out "Open plot in new window" in a Positron Workbench release build!

@timtmok timtmok merged commit 9ea950e into main Jan 30, 2025
9 checks passed
@timtmok timtmok deleted the 6146-plot-editor-flag branch January 30, 2025 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sharon-wang sharon-wang sharon-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtmok @sharon-wang